pr(archai): Fixes notebook-related issues. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t clashing with unitary tests.
lovettchris
approved these changes
Feb 8, 2023
| @@ -1,4 +1,4 @@ | |||
| name: Linter and Tests Runner | |||
| name: Linter and Unitary Tests Runner | |||
There was a problem hiding this comment.
we usually just say "Unit Test", so I'm not sure what "unitary" means... "unit test" means a low level test that is sort of testing one low level function, versus "Integration Test" that is testing more of an end-to-end scenario... is that what you meant by "unitary" ?
There was a problem hiding this comment.
Yes! Sorry about that, I always thought that unit was the short term for unitary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In progress.
Fixes: #155, #167
Changes
Configuration:
Final checks: