Add support for WAM broker #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnterickson
changed the title
johnterickson
force-pushed
the
broker
branch
4 times, most recently
from
950b160
to
5577644
Compare
bgavrilMS
reviewed
Jun 29, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 29, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 29, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 29, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
jmyersmsft
reviewed
Jun 29, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
johnterickson
commented
Jul 12, 2022
CredentialProvider.Microsoft.Tests/CredentialProviders/Vsts/AuthUtilTests.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 25, 2022
CredentialProvider.Microsoft/CredentialProvider.Microsoft.csproj
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 25, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 25, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
johnterickson
changed the title
johnterickson
commented
Sep 2, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/IAuthUtil.cs
Outdated
Show resolved
Hide resolved
johnterickson
commented
Sep 22, 2022
johnterickson
commented
Sep 22, 2022
jmyersmsft
reviewed
Sep 22, 2022
johnterickson
force-pushed
the
broker
branch
from
14bc191
to
d4a4b0b
Compare
johnterickson
commented
Sep 22, 2022
johnterickson
commented
Dec 14, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
johnterickson
commented
Dec 14, 2022
CredentialProvider.Microsoft/CredentialProvider.Microsoft.csproj
Outdated
Show resolved
Hide resolved
don't try to download net6-win files before they exist prefer MSA when authority is unknown trying with BrokerPreview again converge on new broker revert build revert build
johnterickson
force-pushed
the
broker
branch
from
742b0a5
to
1ba8ccd
Compare
Darsstar
reviewed
Dec 30, 2022
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 23, 2023
CredentialProvider.Microsoft/CredentialProviders/Vsts/AdalTokenProvider.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 23, 2023
CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalBearerTokenProvidersFactory.cs
Show resolved
Hide resolved
Tested on Linux now as well. |
JohnSchmeichel
approved these changes
Mar 2, 2023
|
Woo, this works well with Windows after setting NUGET_CREDENTIALPROVIDER_MSAL_ENABLED and NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER. Looking forward to this being pushed to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, I've just tested on Windows.