Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credential provider release build and resolve build warnings #354

Merged
merged 19 commits into from
Nov 18, 2022

Conversation

JohnSchmeichel
Copy link
Member

The release build for ingestion to Visual Studio was broken by service connection remediation so needed to be recreated. Some recent changes in the build templates are now no longer compatible with the build machines running release builds. Also fixing some miscellaneous build and release warnings that have snuck in.

Copy link

@ByAgenT ByAgenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, left one suggestion for the nuget restore step

build/build.yml Outdated Show resolved Hide resolved
@JohnSchmeichel JohnSchmeichel merged commit 2286b12 into master Nov 18, 2022
@JohnSchmeichel JohnSchmeichel deleted the users/johsch/release-fixes branch November 18, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants