Default CanShowDialog to true for stand-alone mode #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embetten
approved these changes
Mar 30, 2023
JohnSchmeichel
force-pushed
the
johsch/dialog-standalone
branch
from
9662e83
to
658947b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning off the CanShowDialog option is meant to be used to force a device code flow, generally only in cases where an interactive prompt can't be used (like headless displays). These cases are fairly rare and the system browser flow has a good experience and is cross platform. And for Windows the WAM Broker account picker is even better as it prompts with configured and cached accounts.
Changing the default for stand-alone mode only so users can get the benefits if tooling is not explicitly disabling the option. Not changing the default for the NuGet protocol at this time, following up with that team on a change to the protocol.