Fix valid host check for vanity urls #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embetten
approved these changes
Apr 19, 2023
JohnSchmeichel
added a commit
that referenced
this pull request
Apr 24, 2023
All of the methods off of IAuthUtil will probe the same url to get response headers. We were making 3 requests for the same response, and after #392 we made one less in the common case. Adding an internal cache to simply cache the response headers by url. It's possible to refactor to make this a little more explicit (e.g. pull the headers once and pass that around) but those changes ended up being quite large and may cause more work with planned changes. Also passing the HttpCompletionOption.ResponseHeadersRead option since we don't care about the request body or any trailing headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid host checks ensure we don't make an extra http probe, but no longer correctly handle the vanity url changes where the organization is no longer part of the host name. Double checked old and new style urls for DevFabric, AppFabric, and prod.