Don't write output to stdout #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing output to stdout breaks the usage of artifacts-keyring with the keyring CLI since it is impossible to discriminate between the output of the CLI and other text writen to stdout.
jenshnielsen
force-pushed
the
write_to_std_err
branch
from
b9f5c99
to
bf62c82
Compare
|
This looks reasonable to me - thank you for your contributions. We will do some validations before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing output to stdout breaks the usage of artifacts-keyring with the keyring CLI since it is impossible to discriminate
between the output of the CLI and other text written to stdout.
See astral-sh/uv#3260 as an example where this is an issue but note that this also affects using a system wide install of keyring as a backend with pip.