Skip to content

Commit

Permalink
Make the port number optional in JupyterConnectionInfo() (#2473)
Browse files Browse the repository at this point in the history
* fix: JupyterConnectionInfo port type

* fix: jupyter_client base_url

* fix: JupyterConnectionInfo
  • Loading branch information
luxuncang committed Apr 22, 2024
1 parent b7366b5 commit 4e13f22
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
6 changes: 3 additions & 3 deletions autogen/coding/jupyter/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ class JupyterConnectionInfo:
"""`str` - Host of the Jupyter gateway server"""
use_https: bool
"""`bool` - Whether to use HTTPS"""
port: int
"""`int` - Port of the Jupyter gateway server"""
token: Optional[str]
port: Optional[int] = None
"""`Optional[int]` - Port of the Jupyter gateway server. If None, the default port is used"""
token: Optional[str] = None
"""`Optional[str]` - Token for authentication. If None, no token is used"""


Expand Down
6 changes: 4 additions & 2 deletions autogen/coding/jupyter/jupyter_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ def _get_headers(self) -> Dict[str, str]:

def _get_api_base_url(self) -> str:
protocol = "https" if self._connection_info.use_https else "http"
return f"{protocol}://{self._connection_info.host}:{self._connection_info.port}"
port = f":{self._connection_info.port}" if self._connection_info.port else ""
return f"{protocol}://{self._connection_info.host}{port}"

def _get_ws_base_url(self) -> str:
return f"ws://{self._connection_info.host}:{self._connection_info.port}"
port = f":{self._connection_info.port}" if self._connection_info.port else ""
return f"ws://{self._connection_info.host}{port}"

def list_kernel_specs(self) -> Dict[str, Dict[str, str]]:
response = self._session.get(f"{self._get_api_base_url()}/api/kernelspecs", headers=self._get_headers())
Expand Down

0 comments on commit 4e13f22

Please sign in to comment.