Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: wrong argument passing? #2763

Closed
adam-osusky opened this issue May 22, 2024 · 1 comment
Closed

[Bug]: wrong argument passing? #2763

adam-osusky opened this issue May 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working rag retrieve-augmented generative agents

Comments

@adam-osusky
Copy link

Describe the bug

else:
chunks, sources = split_files_to_chunks(
get_files_from_dir(self._docs_path, self._custom_text_types, self._recursive),
self._max_tokens,
self._chunk_mode,
self._must_break_at_empty_line,
)

Should not be on line 349 self._chunk_token_size?

Because we want to split by chunk size and not by maximal context size of the LLM.

Steps to reproduce

No response

Model Used

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response

@adam-osusky adam-osusky added the bug Something isn't working label May 22, 2024
@gagb gagb added the rag retrieve-augmented generative agents label Aug 28, 2024
@thinkall
Copy link
Collaborator

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rag retrieve-augmented generative agents
Projects
None yet
Development

No branches or pull requests

3 participants