Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom openai base url in config_list_openai_aoai #762

Closed
thinkall opened this issue Nov 25, 2023 · 4 comments · Fixed by #1046
Closed

Support custom openai base url in config_list_openai_aoai #762

thinkall opened this issue Nov 25, 2023 · 4 comments · Fixed by #1046
Assignees
@olaoluwasalami
Labels
good first issue Good for newcomers

Comments

@thinkall
Copy link
Collaborator

Add support to custom openai base url
image
@thinkall thinkall added the good first issue Good for newcomers label Nov 25, 2023
@olaoluwasalami olaoluwasalami self-assigned this Nov 25, 2023
@sonichi
Copy link
Collaborator

sonichi commented Nov 25, 2023

Why do we need this?

@thinkall
Copy link
Collaborator Author

Why do we need this?

To support local models. Currently, if a local model is defined with environment variables, it won't work.

@sonichi
Copy link
Collaborator

sonichi commented Dec 3, 2023

Why is that? Does openai's Client ignore the base_url?

@sonichi sonichi mentioned this issue Dec 3, 2023
Open
@thinkall
Copy link
Collaborator Author

thinkall commented Dec 4, 2023

Why is that? Does openai's Client ignore the base_url?

If the config is loaded by config_list_openai_aoai, then no base_url will be set. Currently, config_list_from_models will trigger the bug.

@maxim-saplin maxim-saplin mentioned this issue Dec 22, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 30, 2023
@maxim-saplin @ekzhu
[Core] Extending inline docs for openai_utils.py, boosting coverage…
16b1723 
… in `test_utils.py`, fixing #762 (#1046)

* fix for #762 ,get_config_list/oia assetion, docs, test

* Improved docstrings

* test_utils using fake data and temp files

* "Black" formatting applied

* Fix build (KEY_LOC and OAI_CONFIG_LIST as consts in test_client)

* Ramping up openai_utils coverage

* Missing parameter doc.

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this issue Apr 17, 2024
@maxim-saplin @ekzhu
[Core] Extending inline docs for openai_utils.py, boosting coverage…
646ea49 
… in `test_utils.py`, fixing microsoft#762 (microsoft#1046)

* fix for microsoft#762 ,get_config_list/oia assetion, docs, test

* Improved docstrings

* test_utils using fake data and temp files

* "Black" formatting applied

* Fix build (KEY_LOC and OAI_CONFIG_LIST as consts in test_client)

* Ramping up openai_utils coverage

* Missing parameter doc.

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olaoluwasalami olaoluwasalami

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Extending inline docs for openai_utils.py, boosting coverage in test_utils.py, fixing #762
3 participants
@thinkall @sonichi @olaoluwasalami