Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception causes all over the codebase #1007 #1014

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

cool-RR
Copy link
Collaborator

@cool-RR cool-RR commented Dec 18, 2023

Why are these changes needed?

This is a continuation of #1007 for the entire codebase.

@cool-RR
Copy link
Collaborator Author

cool-RR commented Dec 18, 2023

@microsoft-github-policy-service agree

@cool-RR cool-RR marked this pull request as ready for review December 18, 2023 14:47
@cool-RR
Copy link
Collaborator Author

cool-RR commented Dec 18, 2023

@LinxinS97 this is a continuation of #1007

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cb6512d) 30.27% compared to head (7598c48) 40.65%.

Files Patch % Lines
autogen/agentchat/contrib/math_user_proxy_agent.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1014       +/-   ##
===========================================
+ Coverage   30.27%   40.65%   +10.37%     
===========================================
  Files          30       30               
  Lines        3980     3980               
  Branches      897      946       +49     
===========================================
+ Hits         1205     1618      +413     
+ Misses       2696     2233      -463     
- Partials       79      129       +50     
Flag Coverage Δ
unittests 40.60% <0.00%> (+10.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 25, 2023

A small formatting issue see run result.

@ekzhu ekzhu added this pull request to the merge queue Dec 25, 2023
Merged via the queue into microsoft:main with commit 70cc1f4 Dec 25, 2023
76 of 84 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Li Jiang <lijiang1@microsoft.com>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants