Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default model in LMM #1032

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Change default model in LMM #1032

merged 2 commits into from
Dec 22, 2023

Conversation

BeibinLi
Copy link
Collaborator

Why are these changes needed?

Address issue #965

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0288e0) 26.54% compared to head (35c06d8) 37.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1032       +/-   ##
===========================================
+ Coverage   26.54%   37.87%   +11.33%     
===========================================
  Files          28       28               
  Lines        3805     3807        +2     
  Branches      865      907       +42     
===========================================
+ Hits         1010     1442      +432     
+ Misses       2724     2239      -485     
- Partials       71      126       +55     
Flag Coverage Δ
unittests 37.82% <100.00%> (+11.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this is to make sure the model used support multi-modal input correct?

@BeibinLi
Copy link
Collaborator Author

My understanding is that this is to make sure the model used support multi-modal input correct?

Yes, correct. The ConversableAgent defaults to “gpt-4", and we should default to a multimodal model. When the config_list is not set, the default model will be used.

@ekzhu ekzhu added this pull request to the merge queue Dec 22, 2023
Merged via the queue into microsoft:main with commit a1e60e8 Dec 22, 2023
76 of 84 checks passed
@sonichi sonichi deleted the lmm branch December 24, 2023 13:04
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants