Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/typo #1034

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Fix/typo #1034

merged 5 commits into from
Dec 22, 2023

Conversation

KazooTTT
Copy link
Collaborator

Why are these changes needed?

Fix some typographical errors to make the codes more readable.

Related issue number

Checks

@KazooTTT
Copy link
Collaborator Author

@microsoft-github-policy-service agree

Copy link
Contributor

@rickyloynd-microsoft rickyloynd-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These spelling fixes look good to me.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0288e0) 26.54% compared to head (375acb8) 37.87%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1034       +/-   ##
===========================================
+ Coverage   26.54%   37.87%   +11.33%     
===========================================
  Files          28       28               
  Lines        3805     3807        +2     
  Branches      865      907       +42     
===========================================
+ Hits         1010     1442      +432     
+ Misses       2724     2239      -485     
- Partials       71      126       +55     
Flag Coverage Δ
unittests 37.82% <100.00%> (+11.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu self-requested a review December 21, 2023 16:09
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please check the unit test results. It looks like the some doc strings are tested for their token length.

Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. What spell check tool have you used for this PR?

All changes look good, except the failing test cases.

@KazooTTT
Copy link
Collaborator Author

Thanks for the review. What spell check tool have you used for this PR?

All changes look good, except the failing test cases.

Thanks. The tool is pycharm's code inspections.

@ekzhu ekzhu added this pull request to the merge queue Dec 22, 2023
Merged via the queue into microsoft:main with commit a122ffe Dec 22, 2023
76 of 84 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix: typo

* fix: typo

* fix: typo of function name

* fix: typo of function name of test file

* Update test_token_count.py

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants