Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode dump with different pydantic version #1063

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Fix mode dump with different pydantic version #1063

merged 1 commit into from
Dec 26, 2023

Conversation

yiranwu0
Copy link
Collaborator

Why are these changes needed?

Closes #1058

Related issue number

Closes #1058

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b420f1) 30.21% compared to head (4b19b85) 40.66%.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1063       +/-   ##
===========================================
+ Coverage   30.21%   40.66%   +10.44%     
===========================================
  Files          30       30               
  Lines        3988     3989        +1     
  Branches      899      948       +49     
===========================================
+ Hits         1205     1622      +417     
+ Misses       2704     2236      -468     
- Partials       79      131       +52     
Flag Coverage Δ
unittests 40.61% <50.00%> (+10.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ekzhu
ekzhu previously approved these changes Dec 26, 2023
@ekzhu ekzhu added this pull request to the merge queue Dec 26, 2023
@ekzhu ekzhu removed this pull request from the merge queue due to a manual request Dec 26, 2023
@ekzhu ekzhu self-requested a review December 26, 2023 16:56
@ekzhu ekzhu dismissed their stale review December 26, 2023 16:56

rerequest

@ekzhu ekzhu enabled auto-merge December 26, 2023 18:28
@ekzhu ekzhu added this pull request to the merge queue Dec 26, 2023
Merged via the queue into main with commit 9b7a42f Dec 26, 2023
76 of 84 checks passed
@ekzhu ekzhu deleted the fixmode branch December 26, 2023 18:33
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: mode is only supported in Pydantic v2
3 participants