Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix openai dependency error introduced when merging #1044 #1071

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Dec 27, 2023

Why are these changes needed?

Fix dependency error introduced when merging #1044. The openai package version constraint should be >1.3. Removing the constraint <1.5 which was introduced by error.

Related issue number

#1044

Checks

Fix dependency error introduced when merging #1044
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d583ad8) 30.14% compared to head (b3a1ee2) 58.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1071       +/-   ##
===========================================
+ Coverage   30.14%   58.55%   +28.40%     
===========================================
  Files          30       30               
  Lines        4020     4020               
  Branches      908      957       +49     
===========================================
+ Hits         1212     2354     +1142     
+ Misses       2729     1441     -1288     
- Partials       79      225      +146     
Flag Coverage Δ
unittests 58.35% <ø> (+28.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Dec 27, 2023
Merged via the queue into main with commit 14a9672 Dec 27, 2023
81 checks passed
@sonichi sonichi deleted the dependency branch December 27, 2023 19:15
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Fix dependency error introduced when merging microsoft#1044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants