Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that depend on OpenAI via --skip-openai #1097

Merged
merged 11 commits into from
Dec 31, 2023
Merged

Skip tests that depend on OpenAI via --skip-openai #1097

merged 11 commits into from
Dec 31, 2023

Conversation

maxim-saplin
Copy link
Collaborator

Allows skipping test that depend on OpenAI. It is possible to run the whole test suite with openai dependency installed via pytest test --skip-openai (previously it was required to uninstall openai lib to run tests that don't interact with LLM).

Related issue number

Partially closes #1088

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f497710) 30.56% compared to head (e0cc7d1) 40.49%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
+ Coverage   30.56%   40.49%   +9.92%     
==========================================
  Files          30       30              
  Lines        4028     4033       +5     
  Branches      911      962      +51     
==========================================
+ Hits         1231     1633     +402     
+ Misses       2723     2289     -434     
- Partials       74      111      +37     
Flag Coverage Δ
unittests 40.41% <ø> (+9.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sonichi sonichi added this pull request to the merge queue Dec 31, 2023
Merged via the queue into microsoft:main with commit c80df8a Dec 31, 2023
76 of 84 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* add doc for spark

* labelCol equals to label by default

* change title and reformat

* reference about default index type

* fix doc build

* Update website/docs/Examples/Integrate - Spark.md

* update doc

* Added more references

* remove exception case when `y_train.name` is None

* fix broken link

---------

Co-authored-by: Wendong Li <v-wendongli@microsoft.com>
Co-authored-by: Li Jiang <bnujli@gmail.com>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* --skip-openai

* All tests pass

* Update build.yml

* Update Contribute.md

* Fix for failing Ubuntu tests

* More tests skipped, fixing 3.10 build

* Apply suggestions from code review

Co-authored-by: Qingyun Wu <qingyun0327@gmail.com>

* Added more comments

* fixed test__wrap_function_*

---------

Co-authored-by: Qingyun Wu <qingyun0327@gmail.com>
Co-authored-by: Davor Runje <davor@airt.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put all the tests requiring openai in one place and skip/run them in the pytest command in the workflow
5 participants