openai base url default to None; read files when env vars exist; remove deprecated models #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
===========================================
+ Coverage 30.56% 64.76% +34.20%
===========================================
Files 30 30
Lines 4028 4033 +5
Branches 911 962 +51
===========================================
+ Hits 1231 2612 +1381
+ Misses 2723 1154 -1569
- Partials 74 267 +193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
changed the title
sonichi
added
bug
3 tasks
3 tasks
afourney
added a commit
that referenced
this pull request
Jan 2, 2024
afourney
added a commit
that referenced
this pull request
Jan 3, 2024
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Remove GPT-4 as the default model. * Updated test_compressible_agent to work around a bug that would otherwise default to gpt-4. Revist after #1073 is addressed. * Worked around another bug in test_compressible_agent. It seems the config_list was always empty! * Reverted changes to compressible agent. * Noted that GPT-4 is the preferred model in the OAI_CONFIG_LIST_sample and README. * Fixed failing tests after #1110 * Update OAI_CONFIG_LIST_sample Co-authored-by: Chi Wang <wang.chi@microsoft.com> --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with #1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml
mtwalther
pushed a commit
to mtwalther/autogen
that referenced
this pull request
Jan 26, 2024
…#1093) * Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with microsoft#1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml
corleroux
pushed a commit
to corleroux/autogen
that referenced
this pull request
Jan 30, 2024
…#1093) * Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with microsoft#1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* add funccall example and doc * revise to comments * Update website/docs/Use-Cases/Auto-Generation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * revise * update * minor update * add test notebook * update --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…ve deprecated models (microsoft#1110) * openai base url default to None * read from files when env vars exist
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Remove GPT-4 as the default model. * Updated test_compressible_agent to work around a bug that would otherwise default to gpt-4. Revist after microsoft#1073 is addressed. * Worked around another bug in test_compressible_agent. It seems the config_list was always empty! * Reverted changes to compressible agent. * Noted that GPT-4 is the preferred model in the OAI_CONFIG_LIST_sample and README. * Fixed failing tests after microsoft#1110 * Update OAI_CONFIG_LIST_sample Co-authored-by: Chi Wang <wang.chi@microsoft.com> --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…#1093) * Initial commit of WebSurfer. Adds the browser_utils, and related tests. WebSurfer will be added in a subsequent commit. * Added the web surfer agent, and related tests. * Added a notebook to show how WebSurferAgent works. * Fixed a typo. * Updated test_web_surfer for compatibility with microsoft#1110. * Updated skip_oai logic. * Fixed code formatting. * More pre-commit fixes. * Added block to contrib-openai.yml * Added block to contrib-openai.yml * Added hook for BING_API_KEY * Temporarily commented out other tests, per request. * Fixed indentation (maybe?) * Restoring contrib-openai.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
openai_utils.py, boosting coverage intest_utils.py, fixing #762 #1046 introduces a bug of defaulting openai base url to "". It causes test failures in https://github.com/microsoft/autogen/actions/runs/7366572506/job/20050787096?pr=1026This PR changes the default to None.
openai_utils.py, boosting coverage intest_utils.py, fixing #762 #1046 introduces a test which fails with the current utils when env vars already exist: https://github.com/microsoft/autogen/actions/runs/7371478796/job/20058910737?pr=1110This PR changes the utility such that it tries to read from files even when the env vars exist, unless the file path or file names are explicitly set to None.
Related issue number
Checks