Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inappropriate api_type #1190

Merged
merged 1 commit into from Jan 10, 2024
Merged

remove inappropriate api_type #1190

merged 1 commit into from Jan 10, 2024

Conversation

sonichi
Copy link
Collaborator

@sonichi sonichi commented Jan 10, 2024

Why are these changes needed?

When the api type is openai, the key "api_type" is not supposed to appear in the config.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (083ba32) 30.38% compared to head (fc1e67c) 49.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1190       +/-   ##
===========================================
+ Coverage   30.38%   49.72%   +19.33%     
===========================================
  Files          32       32               
  Lines        4302     4302               
  Branches      994     1045       +51     
===========================================
+ Hits         1307     2139      +832     
+ Misses       2901     1959      -942     
- Partials       94      204      +110     
Flag Coverage Δ
unittests 49.62% <ø> (+19.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added documentation Improvements or additions to documentation oai_config_list Issues relating to OAI_CONFIG_LIST handling. labels Jan 10, 2024
@sonichi sonichi added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit b548e55 Jan 10, 2024
81 of 87 checks passed
@sonichi sonichi deleted the apitype branch January 10, 2024 12:43
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation oai_config_list Issues relating to OAI_CONFIG_LIST handling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants