Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tool use from Use-Cases/agent_chat #2120

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Mar 21, 2024

Why are these changes needed?

Removing tool use section from Use-Cases/agent_chat as the content is covered in the tutorial chapter on tool use: https://microsoft.github.io/autogen/docs/tutorial/tool-use

Related issue number

#1597

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.06%. Comparing base (a8abe59) to head (1c04eff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2120   +/-   ##
=======================================
  Coverage   37.06%   37.06%           
=======================================
  Files          68       68           
  Lines        7069     7069           
  Branches     1543     1543           
=======================================
  Hits         2620     2620           
  Misses       4218     4218           
  Partials      231      231           
Flag Coverage Δ
unittests 37.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb self-requested a review March 23, 2024 03:31
Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your edits look good. But I am not confident what role the Use Cases section is serving. The text in it is the seems like intro to autogen, which is already there in getting started?

@ekzhu
Copy link
Collaborator Author

ekzhu commented Mar 23, 2024

Your edits look good. But I am not confident what role the Use Cases section is serving. The text in it is the seems like intro to autogen, which is already there in getting started?

Let's address this in the next PR. I think we will need @sonichi's input regarding moving the content of use-cases.

@ekzhu ekzhu enabled auto-merge March 23, 2024 04:11
@ekzhu ekzhu added this pull request to the merge queue Mar 23, 2024
Merged via the queue into main with commit 01afc9b Mar 23, 2024
27 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants