Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of notebooks #2200

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

martinzrrl
Copy link
Collaborator

@martinzrrl martinzrrl commented Mar 28, 2024

Why are these changes needed?

Improved readability of notebooks with fixed link and typos.

Related issue number

Checks

@martinzrrl
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@sonichi sonichi requested review from ekzhu, gagb and skzhang1 April 1, 2024 13:59
Copy link
Collaborator

@skzhang1 skzhang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.05%. Comparing base (4a44093) to head (c705e6e).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2200       +/-   ##
===========================================
+ Coverage   38.14%   50.05%   +11.91%     
===========================================
  Files          78       78               
  Lines        7865     7865               
  Branches     1683     1821      +138     
===========================================
+ Hits         3000     3937      +937     
+ Misses       4615     3597     -1018     
- Partials      250      331       +81     
Flag Coverage Δ
unittest 14.21% <ø> (?)
unittests 49.02% <ø> (+10.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

update line breaks according to comment of reviewer
corrected sentence according to comment of reviewer
Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
@sonichi sonichi enabled auto-merge April 9, 2024 15:07
@sonichi sonichi added this pull request to the merge queue Apr 9, 2024
Merged via the queue into microsoft:main with commit 918fd6b Apr 9, 2024
60 of 72 checks passed
@martinzrrl martinzrrl deleted the improve-readability branch April 11, 2024 07:03
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Improve readability

* Update context_handling.py

update line breaks according to comment of reviewer

* Update agentchat_groupchat_finite_state_machine.ipynb

corrected sentence according to comment of reviewer

* Update autogen/agentchat/contrib/capabilities/context_handling.py

Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>

---------

Co-authored-by: Shaokun Zhang <shaokunzhang529@gmail.com>
Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants