-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add silent option in nested chats and group chat #2712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
robraux
changed the title
feat: respect silent request in nested chats and group chat
Add silent option in nested chats and group chat
May 17, 2024
ekzhu
reviewed
May 22, 2024
ekzhu
approved these changes
May 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 22, 2024
3 tasks
jayralencar
pushed a commit
to jayralencar/autogen
that referenced
this pull request
May 28, 2024
* feat: respect silent request in nested chats and group chat * fix: address plugin test --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
victordibia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* feat: respect silent request in nested chats and group chat * fix: address plugin test --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
silent
parameter is useful when dealing with deeply orchestrated workflows on the CLI. This adds additional support for respecting this useful configuration in the more complex orchestrators.__post_carryover_processing
messaging.Decisions
silent=True
as these add no value to display.silent
configuration tweaked to support the plugin use case without adding additional vars toConversableAgent
.Related issue number
Replaces PR: #2212
Closes: #1335
Checks