Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async test #520

Merged
merged 21 commits into from
Dec 19, 2023
Merged

Add async test #520

merged 21 commits into from
Dec 19, 2023

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Nov 1, 2023

Why are these changes needed?

Adds a test notebook for async function calls (including group chat)

Related issue number

#517

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (083f522) 26.63% compared to head (ebf5811) 26.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   26.63%   26.63%           
=======================================
  Files          28       28           
  Lines        3777     3777           
  Branches      858      858           
=======================================
  Hits         1006     1006           
  Misses       2700     2700           
  Partials       71       71           
Flag Coverage Δ
unittests 26.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb
Copy link
Collaborator Author

gagb commented Dec 10, 2023

It's better to add a link to the added notebook as soon as it is added.

Fixed. And thanks Chi, will keep in mind for future PRs.

@sonichi sonichi added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 03b819b Dec 19, 2023
16 of 19 checks passed
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 25, 2023
* Add example nb for async funcs

* Add a notebook based test for async function calls

* Update nb

* Update nb

* Remove duplicate code

* Rename func for consistency

* Fix bug

* Add intro text for cmd cell 4

* Add a short comment on await

* Update agentchat_function_call_async.ipynb

Minor typo

* Add link to nb

---------

Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
@qingyun-wu qingyun-wu deleted the async-test branch February 13, 2024 16:53
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add example nb for async funcs

* Add a notebook based test for async function calls

* Update nb

* Update nb

* Remove duplicate code

* Rename func for consistency

* Fix bug

* Add intro text for cmd cell 4

* Add a short comment on await

* Update agentchat_function_call_async.ipynb

Minor typo

* Add link to nb

---------

Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants