Makes select_speaker more robust by checking for mentions anywhere. #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where in the selection string. Addresses 663.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 28.89% 37.36% +8.46%
==========================================
Files 27 27
Lines 3395 3407 +12
Branches 764 767 +3
==========================================
+ Hits 981 1273 +292
+ Misses 2342 2017 -325
- Partials 72 117 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeibinLi
approved these changes
Nov 13, 2023
This was referenced Nov 15, 2023
|
Thanks. I'm happy either way, but personally find complex list compressions take longer to read/understand. If it's all the same to you, I'd rather just leave it step by step. |
sonichi
reviewed
Nov 16, 2023
…er to own function.
Yes done. To test this effectively, I needed to separate some of the logic out as a helper function |
qingyun-wu
approved these changes
Nov 17, 2023
sonichi
reviewed
Nov 17, 2023
| ) # Finds agent mentions, taking word boundaries into account | ||
| count = len(re.findall(regex, " " + message_content + " ")) # Pad the message to help with matching | ||
| if count > 0: | ||
| mentions[agent.name] = count |
There was a problem hiding this comment.
Early stop is still applicable here.
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…icrosoft#669) * Makes select_speaker more robust by checking for agents mentioned anywhere in the selection string. Addresses 663. * Added test coverage for group chat mentions. Refactored mention counter to own function. * Fixed pre-commit formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes select_speaker more robust by checking for agent name mentions anywhere in the string returned by the LLM.
Why are these changes needed?
Selecting the speaker fails when the LLM returns anything other than an exact agent name.
Related issue number
Closes #663, and perhaps a few others.
Edit: I just saw #668, which is a different problem, but might be related?
Checks