Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agentchat_oai_assistant_retrieval.ipynb #732

Merged
merged 3 commits into from Nov 22, 2023
Merged

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Nov 21, 2023

Why are these changes needed?

change our -> your in retrieval nb for gpt assistant to reduce confusion

Related issue number

#731

Checks

our -> your to reduce confusion
@gagb gagb marked this pull request as ready for review November 21, 2023 06:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d22664f) 27.89% compared to head (ddf999c) 27.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   27.89%   27.89%           
=======================================
  Files          27       27           
  Lines        3466     3466           
  Branches      784      784           
=======================================
  Hits          967      967           
  Misses       2428     2428           
  Partials       71       71           
Flag Coverage Δ
unittests 27.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb requested review from thinkall and LeoLjl November 21, 2023 22:52
@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 8f7f870 Nov 22, 2023
16 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Update agentchat_oai_assistant_retrieval.ipynb

our -> your to reduce confusion

* Update notebook/agentchat_oai_assistant_retrieval.ipynb

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants