Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allow_repeat_speaker to be a list of agents #905

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

afourney
Copy link
Member

@afourney afourney commented Dec 7, 2023

Why are these changes needed?

At present, allow_repeat_speaker must be a boolean. If True, then all agents can repeat. If False, then no agents can repeat. This PR allows developers to assign a list to allow_repeat_speaker. If an agent is in the list, then it is allowed to speak consecutively (if the GroupChat desires), otherwise it cannot repeat. This is useful because some agents benefit from repetition (e.g., the AssistantAgent), where others really should not repeat (e.g., the UserProxy).

Related issue number

N/A

Checks

…o repeat, rather than just a global boolean.
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (605882b) 26.46% compared to head (5b38b66) 24.04%.
Report is 5 commits behind head on main.

Files Patch % Lines
autogen/agentchat/groupchat.py 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
- Coverage   26.46%   24.04%   -2.43%     
==========================================
  Files          28       26       -2     
  Lines        3801     3797       -4     
  Branches      865      865              
==========================================
- Hits         1006      913      -93     
- Misses       2724     2761      +37     
- Partials       71      123      +52     
Flag Coverage Δ
unittests 24.04% <81.81%> (-2.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi requested a review from BeibinLi December 7, 2023 14:29
@joshkyh joshkyh mentioned this pull request Dec 13, 2023
3 tasks
Merged via the queue into main with commit dd4a2da Dec 18, 2023
78 of 84 checks passed
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
…o repeat, rather than just a global boolean. (microsoft#905)

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
@afourney afourney deleted the repeat_speaker_list branch January 23, 2024 17:13
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* add cost budget; move loc of make_dir

* support openai completion

* install pytest in workflow

* skip openai test

* test openai

* path for docs rebuild

* install datasets

* signal

* notebook

* notebook in workflow

* optional arguments and special params

* key -> k

* improve readability

* assumption

* optimize for model selection

* larger range of max_tokens

* notebook

* python package workflow

* skip on win
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…o repeat, rather than just a global boolean. (microsoft#905)

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants