Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple chat app #921

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Simple chat app #921

merged 7 commits into from
Dec 12, 2023

Conversation

danyrouh
Copy link
Collaborator

@danyrouh danyrouh commented Dec 8, 2023

This PR provides a very simple python script for beginners to get started. It replicates the basic chatgpt-like conversational experience.

Why are these changes needed?

Many new users struggle to run the NVDA-TESLA example or the notebooks, since they all involve various kinds of complexity.

Related issue number

#919

Checks

Initial implementation
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cec541) 26.63% compared to head (c5fd8b1) 26.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   26.63%   26.63%           
=======================================
  Files          28       28           
  Lines        3777     3777           
  Branches      858      858           
=======================================
  Hits         1006     1006           
  Misses       2700     2700           
  Partials       71       71           
Flag Coverage Δ
unittests 26.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Implementation
Copy link
Contributor

@rickyloynd-microsoft rickyloynd-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine for me.

Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Shall we add a link from README or https://microsoft.github.io/autogen/docs/Getting-Started to this example?
cc @qingyun-wu @skzhang1 what's a good place on the website to add a link to this example?

samples/simple_chat.py Outdated Show resolved Hide resolved
@skzhang1
Copy link
Collaborator

skzhang1 commented Dec 9, 2023

Thanks. Shall we add a link from README or https://microsoft.github.io/autogen/docs/Getting-Started to this example? cc @qingyun-wu @skzhang1 what's a good place on the website to add a link to this example?

How about putting the link in Human involvement section with title Simple example in ChatGPT style? If you think so, I will make a PR accordingly.
I think the examples in the readme and quick start sections are also simple, there is no need to include this example in those sections.

@rickyloynd-microsoft
Copy link
Contributor

Thanks. Shall we add a link from README or https://microsoft.github.io/autogen/docs/Getting-Started to this example? cc @qingyun-wu @skzhang1 what's a good place on the website to add a link to this example?

How about putting the link in Human involvement section with title Simple example in ChatGPT style? If you think so, I will make a PR accordingly. I think the examples in the readme and quick start sections are also simple, there is no need to include this example in those sections.

A link in the Human Involvement section would make sense. I also think many beginners would appreciate a super-simple example mentioned on the README page. A very short section titled "Simple example in ChatGPT style" could be inserted between the current Installation and Multi-Agent Conversation Framework sections. This new section might contain just a single sentence of explanation, and a link to the example code. The Quickstart section directs readers to the notebooks, but none of those are as simple as this example.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
samples/simple_chat.py Outdated Show resolved Hide resolved
@skzhang1 skzhang1 added this pull request to the merge queue Dec 12, 2023
Merged via the queue into microsoft:main with commit 3a768c3 Dec 12, 2023
16 checks passed
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
* Add file

Initial implementation

* Add file

Implementation

* 1. update readme 2. update web example 3. update code

* update readme

* remove working dir

* update

---------

Co-authored-by: “skzhang1” <“shaokunzhang529@gmail.com”>
Co-authored-by: Shaokun Zhang <shaokunzhang529@gmail.com>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add file

Initial implementation

* Add file

Implementation

* 1. update readme 2. update web example 3. update code

* update readme

* remove working dir

* update

---------

Co-authored-by: “skzhang1” <“shaokunzhang529@gmail.com”>
Co-authored-by: Shaokun Zhang <shaokunzhang529@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants