Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out candidates with the same name but different instructions, … #925

Merged
merged 13 commits into from
Dec 27, 2023

Conversation

IANTHEREAL
Copy link
Collaborator

@IANTHEREAL IANTHEREAL commented Dec 9, 2023

Why are these changes needed?

Filter out candidates with the same name but different instructions, file IDs, and function names.

Related issue number

Refer #892

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dd516f2) 30.23% compared to head (011ba75) 57.13%.

Files Patch % Lines
autogen/oai/openai_utils.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #925       +/-   ##
===========================================
+ Coverage   30.23%   57.13%   +26.90%     
===========================================
  Files          30       30               
  Lines        3989     4020       +31     
  Branches      899      957       +58     
===========================================
+ Hits         1206     2297     +1091     
+ Misses       2704     1512     -1192     
- Partials       79      211      +132     
Flag Coverage Δ
unittests 56.91% <94.28%> (+26.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IANTHEREAL IANTHEREAL marked this pull request as ready for review December 9, 2023 03:11
@sonichi sonichi added this pull request to the merge queue Dec 27, 2023
Merged via the queue into microsoft:main with commit d583ad8 Dec 27, 2023
80 of 84 checks passed
@IANTHEREAL IANTHEREAL deleted the gpt-assistant-improving branch December 28, 2023 01:46
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* update config

* apply precommit
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
microsoft#925)

* Filter out candidates with the same name but different instructions, file IDs, and function names

* polish

* improve log

* improving log

* improve log

* Improve function signature (microsoft#2)

* try to fix ci

* try to fix ci

---------

Co-authored-by: gagb <gagb@users.noreply.github.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openai-assistant Issues related to assistants from OpenAI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants