Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dotnet] Add dotnet build workflow #946

Merged
merged 19 commits into from
Dec 30, 2023
Merged

[Dotnet] Add dotnet build workflow #946

merged 19 commits into from
Dec 30, 2023

Conversation

LittleLittleCloud
Copy link
Collaborator

@LittleLittleCloud LittleLittleCloud commented Dec 12, 2023

Why are these changes needed?

Add build/test/notebook test workflow for dotnet AutoGen package which will be introduced by #924

Related issue number

Checks

@LittleLittleCloud LittleLittleCloud marked this pull request as ready for review December 12, 2023 01:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9388bae) 30.14% compared to head (745b581) 30.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   30.14%   30.14%           
=======================================
  Files          30       30           
  Lines        4020     4020           
  Branches      908      908           
=======================================
  Hits         1212     1212           
  Misses       2729     2729           
  Partials       79       79           
Flag Coverage Δ
unittests 30.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 13, 2023

Just curious does this allow C# program to use this package?

@ekzhu ekzhu self-assigned this Dec 14, 2023
@ekzhu
Copy link
Collaborator

ekzhu commented Dec 14, 2023

Looks good to me. Rust and Golang integration would be lovely too.

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
@ekzhu ekzhu assigned LittleLittleCloud and ekzhu and unassigned ekzhu Dec 25, 2023
@ekzhu
Copy link
Collaborator

ekzhu commented Dec 27, 2023

Added back dotnet environment. @LittleLittleCloud does this environment needs to have API keys?

@LittleLittleCloud
Copy link
Collaborator Author

Added back dotnet environment. @LittleLittleCloud does this environment needs to have API keys?

Yes, some tests need openai keys to run, I'll add them later

@ekzhu ekzhu changed the title Add dotnet build workflow [Dotnet] Add dotnet build workflow Dec 29, 2023
Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions about the change in the existing worflow.

.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
@sonichi sonichi added this pull request to the merge queue Dec 30, 2023
Merged via the queue into main with commit 2d3ed96 Dec 30, 2023
16 checks passed
@sonichi sonichi deleted the u/xiaoyun/1211 branch December 30, 2023 02:26
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* update

* update doc

---------

Co-authored-by: “skzhang1” <“shaokunzhang529@gmail.com”>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* update

* add openai workflow

* Update pre-commit.yml

* Update run_openai_test_and_notebooks.yml

* Update pre-commit.yml

* Update .github/workflows/pre-commit.yml

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Update run_openai_test_and_notebooks.yml

* Update run_openai_test_and_notebooks.yml

* Update run_openai_test_and_notebooks.yml

* Update pre-commit.yml

* Update .pre-commit-config.yaml

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants