Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG] Warning NU5128 in builds #335

Closed
DaveTryon opened this issue Mar 25, 2020 · 1 comment · Fixed by #336
Closed

[ENG] Warning NU5128 in builds #335

DaveTryon opened this issue Mar 25, 2020 · 1 comment · Fixed by #336
Labels
category: engineering status: ready for triage This issue is ready to be triaged by the Accessibility Insights team.

Comments

@DaveTryon
Copy link
Contributor

DaveTryon commented Mar 25, 2020 •
edited

Please check whether the bug has already been filed.

Describe the bug

Starting with commit 17c1319, we're getting the following warning during PR builds and signed builds

warning : NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below: [d:\a\1\s\src\CI\CI.csproj]

  • Add a dependency group for .NETStandard2.0 to the nuspec

According to the documentation, this is a warning that didn't exist in previous versions of NuGet and seems to be related to using the new tools. The docs also offer a couple of options to remove this warning. We should figure out how to address this warning so that our builds are as clean as possible.
@DaveTryon DaveTryon added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. category: engineering labels Mar 25, 2020
@ghost ghost assigned adarshrema Mar 25, 2020
@ghost
Copy link

ghost commented Mar 25, 2020

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost added the status: new This issue is new and requires triage by DRI. label Mar 25, 2020
@ghost ghost assigned RobGallo Mar 25, 2020
@DaveTryon DaveTryon removed the status: new This issue is new and requires triage by DRI. label Mar 25, 2020
@DaveTryon DaveTryon changed the title [ENG] Warning NU5128 in PR builds [ENG] Warning NU5128 in builds Mar 25, 2020
RobGallo added a commit to RobGallo/axe-windows that referenced this issue Mar 26, 2020
@RobGallo
Add dependency group for .Net Standard 2.0 to nuspec
94844fd 
Addresses Issue microsoft#335 - [ENG] Warning NU5128 in builds

This change should match the target frameworks of the dependencies specified in the nuspec file to the frameworks of the assemblies contained in the nuget package.
@RobGallo RobGallo mentioned this issue Mar 26, 2020
Merged
RobGallo added a commit that referenced this issue Mar 26, 2020
@RobGallo
Add dependency group for .Net Standard 2.0 to nuspec (#336)
e5aac85 
Addresses Issue #335 - [ENG] Warning NU5128 in builds

This change should match the target frameworks of the dependencies specified in the nuspec file to the frameworks of the assemblies contained in the nuget package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: engineering status: ready for triage This issue is ready to be triaged by the Accessibility Insights team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dependency group for .Net Standard 2.0 to nuspec RobGallo/axe-windows
3 participants
@RobGallo @DaveTryon @adarshrema