Fixed styling of components by using a newer version of style-loader #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This should come into the master branch, any idea how to approve this PR and have it completed? |
|
This needs to be merged. Current status is highly misleading. |
|
This is an important fix, otherwise the CSS in the scaffolded template code won't work. |
|
@scottdallamura are you able to merge this PR? |
mahomedalid
approved these changes
Aug 9, 2023
|
These changes were included in #153. The PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded version of style-loader since styling wasn't working for me, same issue as #109. Used
asset/inlinefeature of webpack 5,base64-inline-loaderis now unnecessary.