Added initial set of tests for vsoClient #218
Conversation
|
@stephenmichaelf I think I was pretty much able to cover this with L0 tests, did you have anything specific in mind that should be tested at L1 level? Or was that more for expanding this to other APIs in the future? |
|
Are you now able to make PRs from the repo instead of your fork? Want to make sure permissions are correct. |
| target.test = function() { | ||
| target.units(); |
There was a problem hiding this comment.
In the previous version you had one more test here, did you mean to remove that too?
There was a problem hiding this comment.
Yeah, that was the test that had been a placeholder which I got rid of
| @@ -6,8 +6,9 @@ | |||
| "types": "./WebApi.d.ts", | |||
| "scripts": { | |||
| "build": "node make.js build", | |||
| "samples": "node make.js samples && node samples/run.js", | |||
There was a problem hiding this comment.
Can we make this run like the other samples? For the other ones we do e.g. - npm run samples creation... for this we can do npm run samples react?
There was a problem hiding this comment.
Was this meant to be on this PR microsoft/typed-rest-client#86? The react sample is in typed-rest-client and I think this one already exhibits that behavior, I might be misunderstanding the comment though.
test/units/vsoClientTests.ts
Outdated
| let rest: rm.RestClient; | ||
| let vsoClient: vsom.VsoClient | ||
| const baseUrl: string = 'https://dev.azure.com/'; | ||
| before(() => { |
There was a problem hiding this comment.
Nit: add line between const and before.
|
Yes, I am now able to make PRs from the repo |
Divided into unit/non-unit tests, currently no non-unit tests added.
Addresses #217