Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beginGetAreaLocations #567

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Fix beginGetAreaLocations #567

merged 3 commits into from
Nov 7, 2023

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Sep 3, 2023 •
edited
Loading

Fixes #565

Changes:

  • Add null-check for return from options - if it's null, return empty object
  • Add more explicit return type for beginGetLocation - it can return undefined

@KonstantinTyukalov KonstantinTyukalov marked this pull request as ready for review September 3, 2023 17:16
@KonstantinTyukalov KonstantinTyukalov mentioned this pull request Sep 3, 2023
Closed
@KonstantinTyukalov KonstantinTyukalov merged commit fa534ae into master Nov 7, 2023
8 checks passed
@KonstantinTyukalov KonstantinTyukalov deleted the users/KonstantinTyukalov/Fix_beginGetAreaLocations branch November 7, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmapetr vmapetr vmapetr approved these changes

@DergachevE DergachevE DergachevE approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VsoClient and not existing ADO
4 participants
@KonstantinTyukalov @vmapetr @DergachevE @kirill-ivlev