[Task 1872013] add default value for region, pricing tier, os, webContainer and java… #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andxu
commented
Sep 18, 2021
.../src/main/java/com/microsoft/azure/toolkit/lib/appservice/task/CreateOrUpdateWebAppTask.java
Outdated
Show resolved
Hide resolved
andxu
force-pushed
the
andy-default-value
branch
from
565873d
to
d249827
Compare
andxu
force-pushed
the
andy-default-value
branch
from
d249827
to
9a4962a
Compare
andxu
commented
Sep 21, 2021
.../src/main/java/com/microsoft/azure/toolkit/lib/appservice/task/CreateOrUpdateWebAppTask.java
Outdated
Show resolved
Hide resolved
andxu
commented
Sep 21, 2021
...ce-lib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/config/AppServiceConfig.java
Outdated
Show resolved
Hide resolved
...ib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/utils/AppServiceConfigUtils.java
Outdated
Show resolved
Hide resolved
andxu
commented
Sep 22, 2021
...ce-lib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/config/AppServiceConfig.java
Outdated
Show resolved
Hide resolved
2. use reflection api to merge objects.
Flanker32
reviewed
Sep 22, 2021
azure-webapp-maven-plugin/src/main/java/com/microsoft/azure/maven/webapp/DeployMojo.java
Outdated
Show resolved
Hide resolved
Flanker32
reviewed
Sep 22, 2021
...ib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/utils/AppServiceConfigUtils.java
Show resolved
Hide resolved
Flanker32
reviewed
Sep 22, 2021
...ib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/utils/AppServiceConfigUtils.java
Show resolved
Hide resolved
Flanker32
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Version
AB#1872013