Use auth-helper to auth webapp&functions. #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Use auth-helper to auth webapp&functions.
Codecov Report
@@ Coverage Diff @@
## develop #843 +/- ##
=============================================
- Coverage 45.08% 44.55% -0.54%
+ Complexity 768 765 -3
=============================================
Files 133 134 +1
Lines 5119 5169 +50
Branches 729 742 +13
=============================================
- Hits 2308 2303 -5
- Misses 2640 2692 +52
- Partials 171 174 +3
Continue to review full report at Codecov.
|
Flanker32
reviewed
Oct 8, 2019
| @@ -0,0 +1,43 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | |||
There was a problem hiding this comment.
Why we move the resources to spring-cloud-maven-common ?
Flanker32
reviewed
Oct 8, 2019
Comment on lines
+298
to
+313
| if (this.settings.getServer(auth.getServerId()) != null) { | ||
| try { | ||
| auth = MavenSettingHelper.getAuthConfigurationFromServer(session, settingsDecrypter, auth.getServerId()); | ||
| } catch (MavenDecryptException e) { | ||
| throw new AzureAuthFailureException(e.getMessage()); | ||
| } | ||
| } else { | ||
| throw new AzureAuthFailureException(String.format("Unable to get server('%s') from settings.xml.", auth.getServerId())); | ||
| } | ||
| } | ||
|
|
||
| final List<ConfigurationProblem> problems = auth.validate(); | ||
| if (problems.stream().anyMatch(problem -> problem.getSeverity() == Severity.ERROR)) { | ||
| throw new AzureAuthFailureException(String.format("Unable to validate auth configuration due to the following errors: %s", | ||
| problems.stream().map(ConfigurationProblem::getErrorMessage).collect(Collectors.joining("\n")))); | ||
| } |
There was a problem hiding this comment.
Shall we move the check of server id as well as the validation to MavenSettingHelper.getAuthConfigurationFromServer
Flanker32
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use auth-helper to auth webapp&functions.