Support Windows Java SE runtime #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #850 +/- ##
=============================================
+ Coverage 44.55% 44.75% +0.19%
Complexity 765 765
=============================================
Files 134 134
Lines 5169 5146 -23
Branches 742 737 -5
=============================================
Hits 2303 2303
+ Misses 2692 2669 -23
Partials 174 174
Continue to review full report at Codecov.
|
andxu
reviewed
Oct 12, 2019
| Files.copy(jar, new File(parent, jar.getName())); | ||
| WebAppUtils.generateWebConfigFile(deployTarget, jar.getName(), stagingDirectoryPath, log); | ||
| } | ||
| Files.copy(jar, new File(parent, DEFAULT_LINUX_JAR_NAME)); |
There was a problem hiding this comment.
DEFAULT_LINUX_JAR_NAME should be renamed to DEFAULT_JAR_NAME ?
There was a problem hiding this comment.
DEFAULT_LINUX_JAR_NAME and DEFAULT_JAVA_SE_JAR_NAME are same?
There was a problem hiding this comment.
yes, we need rename the executable jar file to app.jar, both for windows and linux
There was a problem hiding this comment.
Renamed to DEFAULT_APP_SERVICE_JAR_NAME
andxu
reviewed
Oct 12, 2019
| @@ -27,6 +27,10 @@ | |||
|
|
|||
| public static final String RUNTIME_CONFIG_REFERENCE = "https://aka.ms/maven_webapp_runtime"; | |||
|
|
|||
| static { | |||
| WebContainer.fromString("java 11"); // Add Java 11 Enum as Fluent SDK had not added it yet | |||
andxu
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Windows Java SE runtime, remove old workaround(
web.config)