Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in renaming jar artifact #865

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Fix issues in renaming jar artifact #865

merged 2 commits into from
Oct 22, 2019

Conversation

Flanker32
Copy link
Member

  • Don't rename artifact when its name equals app.jar
  • Use File.renameTo instead of FileUtils.rename() as FileUtils will delete the origin file when original file name equalsIgnoreCase with app.jar

@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #865 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #865      +/-   ##
=============================================
+ Coverage      44.54%   44.55%   +<.01%     
  Complexity       765      765              
=============================================
  Files            134      134              
  Lines           5170     5169       -1     
  Branches         742      744       +2     
=============================================
  Hits            2303     2303              
+ Misses          2693     2692       -1     
  Partials         174      174
Impacted Files Coverage Δ Complexity Δ
...ebapp/handlers/artifact/ArtifactHandlerImplV2.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99087cd...b7e95a5. Read the comment docs.

@andxu
Copy link
Contributor

andxu commented Oct 22, 2019

Please create the zip file in temp folder during deploying and try to delete it

@Flanker32 Flanker32 merged commit dbc97e7 into develop Oct 22, 2019
@Flanker32 Flanker32 deleted the hanxiao/fixRename branch October 22, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants