Fix escaping property values. (#311)

Properly escape property value to handle non string types
microsoft · Feb 8, 2018 · b7b47e4 · b7b47e4
1 parent 91e03a1
commit b7b47e4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/node/package.json b/node/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vsts-task-lib",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "description": "VSTS Task SDK",
   "main": "./task.js",
   "typings": "./task.d.ts",

diff --git a/node/taskcommand.ts b/node/taskcommand.ts
@@ -32,7 +32,9 @@ export class TaskCommand {
                 if (this.properties.hasOwnProperty(key)) {
                     var val = this.properties[key];
                     if (val) {
-                        cmdStr += key + '=' + escape(val) + ';';
+                        // safely append the val - avoid blowing up when attempting to
+                        // call .replace() if message is not a string for some reason
+                        cmdStr += key + '=' + escape('' + (val || '')) + ';';
                     }
                 }
             }

diff --git a/node/test/commandtests.ts b/node/test/commandtests.ts
@@ -55,6 +55,16 @@ describe('Command Tests', function () {
         done();
     })
 
+    it('toString handles non string value in properties', function (done) {
+        this.timeout(1000);
+
+        var tc = new tcm.TaskCommand('some.cmd', { foo: ['bar', 'baz'] }, 'cr \r lf \n crlf \r\n eom ] ;');
+        assert(tc, 'TaskCommand constructor works');
+        var cmdStr = tc.toString();
+        assert.equal(cmdStr, '##vso[some.cmd foo=bar,baz;]cr %0D lf %0A crlf %0D%0A eom ] ;');
+        done();
+    })
+
     it ('toString escapes properties', function (done) {
         this.timeout(1000);