Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TaskLibAnswers to have all supported commands #332

Merged
merged 3 commits into from Mar 21, 2018
Merged

Update TaskLibAnswers to have all supported commands #332

merged 3 commits into from Mar 21, 2018

Conversation

brcrista
Copy link
Contributor

@brcrista brcrista commented Mar 16, 2018

These are all the commands that are looked up in MockAnswers in mock-task and mock-toolrunner.
With this change, we should stop using type assertions to force the TaskLibAnswers type when we set up the mocks for our L0 tests.
This will allow test authors to catch commands they think are being mocked but are not.

Copy link
Contributor

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brcrista
Copy link
Contributor Author

Someone will have to merge this once it has sign off. I don't have write permissions for this repo.

@stephenmichaelf
Copy link
Member

LGTM

@stephenmichaelf stephenmichaelf merged commit 54cba4e into microsoft:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants