Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing logging commands #361

Merged
merged 2 commits into from May 18, 2018
Merged

Added missing logging commands #361

merged 2 commits into from May 18, 2018

Conversation

mmajcica
Copy link
Contributor

Certain logging commands were not implemented in the PS SDK. Added the missing ones as requested by #310

.PARAMETER AsOutput
Indicates whether to write the logging command directly to the host or to the output pipeline.
#>
function Write-SetEndpointField {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this SetEndpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was in doubt meanwhile creating it, went for Field as it may indicate more precisely the action behind. Hoewer Write-SetEndpoint is also ok by me.

@ericsciple ericsciple merged commit 29a04de into microsoft:master May 18, 2018
@mmajcica mmajcica deleted the MissingLoggingCommands branch May 18, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants