[ToolRunner] Enhanced 'shell' execution option #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-erofeev
approved these changes
Jun 10, 2020
alexander-smolyakov
approved these changes
Jun 10, 2020
2 tasks
|
Could you add some tests for this change please? |
anatolybolshakov
approved these changes
Jun 11, 2020
anatolybolshakov
approved these changes
Jun 18, 2020
alexander-smolyakov
approved these changes
Jun 18, 2020
damccorm
suggested changes
Jun 18, 2020
|
@damccorm Thank you very much for the review! I've applied changes in accordance with your review points so could you please take a look? |
damccorm
approved these changes
Jun 18, 2020
|
Failing windows test is unrelated, I'm going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for #637
Required to fix issue #12848.
Required for PR #13099
Applied enhancement for
shelloption to wrap a tool path and arguments with double quotes to ensure that command is handled correctly if it is executed inside shell. The path and arguments are wrapped only ifshellproperty ofIExecOptionsobject set to true.Added tests.