-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipping the file if it was not found #774
Merged
DenisRumyantsev
merged 5 commits into
master
from
users/DenisRumyantsev/fix-14816-gradle-task
Jul 16, 2021
Merged
Skipping the file if it was not found #774
DenisRumyantsev
merged 5 commits into
master
from
users/DenisRumyantsev/fix-14816-gradle-task
Jul 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please bump package version also |
anatolybolshakov
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
alexander-smolyakov
approved these changes
Jul 15, 2021
EzzhevNikita
approved these changes
Jul 16, 2021
DenisRumyantsev
added a commit
that referenced
this pull request
Jul 16, 2021
Implemented checking for the presence of a file and skipping it if it does not exist
DenisRumyantsev
added a commit
that referenced
this pull request
Jul 16, 2021
This reverts commit 80eaeb9.
DenisRumyantsev
added a commit
that referenced
this pull request
Jul 19, 2021
DergachevE
pushed a commit
that referenced
this pull request
Apr 26, 2024
Implemented checking for the presence of a file and skipping it if it does not exist
DergachevE
pushed a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit d4ba002.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: occasionally the
find
function fails with the errorFailed find: ENOENT: no such file or directory
. The reason is that thefs.lstatSync
method applies to a file that already was deleted. So we should check a file presence and skip it if it does not exist.Changelog:
node/task.ts
— thefind
function — checking a file presence added.Related issue