Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping the file if it was not found #774

Merged
merged 5 commits into from
Jul 16, 2021

Conversation

DenisRumyantsev
Copy link
Contributor

@DenisRumyantsev DenisRumyantsev commented Jul 9, 2021

Description: occasionally the find function fails with the error Failed find: ENOENT: no such file or directory. The reason is that the fs.lstatSync method applies to a file that already was deleted. So we should check a file presence and skip it if it does not exist.

Changelog: node/task.ts — the find function — checking a file presence added.

Related issue

@DenisRumyantsev DenisRumyantsev requested a review from a team July 9, 2021 08:20
@DenisRumyantsev DenisRumyantsev self-assigned this Jul 9, 2021
@anatolybolshakov
Copy link
Contributor

Please bump package version also

node/task.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexander-smolyakov alexander-smolyakov requested a review from a team July 15, 2021 13:33
@DenisRumyantsev DenisRumyantsev merged commit 80eaeb9 into master Jul 16, 2021
DenisRumyantsev added a commit that referenced this pull request Jul 16, 2021
Implemented checking for the presence of a file and skipping it if it does not exist
DenisRumyantsev added a commit that referenced this pull request Jul 16, 2021
DenisRumyantsev added a commit that referenced this pull request Jul 19, 2021
DergachevE pushed a commit that referenced this pull request Apr 26, 2024
Implemented checking for the presence of a file and skipping it if it does not exist
DergachevE pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants