Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node16 to task.schema.json #852

Conversation

AndreyIvanov42
Copy link
Contributor

@AndreyIvanov42 AndreyIvanov42 commented Jul 27, 2022

Task description

Node16 must be specified as a valid property in task.schema.json.

Changelog

  • Added Node16 to task.schema.json
  • Added MockTestRunner with Node16

@AndreyIvanov42 AndreyIvanov42 requested a review from a team July 27, 2022 10:43
@AndreyIvanov42 AndreyIvanov42 changed the base branch from releases/4.x to master July 27, 2022 10:48
@AndreyIvanov42 AndreyIvanov42 changed the base branch from master to releases/4.x July 27, 2022 10:48
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/added-node16-to-task-schema-json branch from 4d762cb to 6cdf60e Compare July 27, 2022 11:14
@AndreyIvanov42 AndreyIvanov42 self-assigned this Jul 27, 2022
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/added-node16-to-task-schema-json branch from 92e5cc9 to 6cdf60e Compare July 28, 2022 15:17
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran unit tests locally on node 10.24.1 and 16.16.0. LGTM, thanks!

@AndreyIvanov42 AndreyIvanov42 merged commit 6fd3bab into releases/4.x Jul 28, 2022
@AndreyIvanov42 AndreyIvanov42 deleted the users/v-andivanov/added-node16-to-task-schema-json branch July 28, 2022 16:20
@AndreyIvanov42 AndreyIvanov42 mentioned this pull request Aug 30, 2022
KonstantinTyukalov added a commit that referenced this pull request Dec 2, 2022
* Migrating to Node 16 (#844)

* create new release/4.x branch

* release for 4 version

* update pipeline

* update package.json

* fix test and build commands

* fixed tests on node18

* change image version for linux

* fix test for linux

* add separete test for linux

* node v16.13

* add v16.13.0 to test

* test on windows-2022, macOS-11

* separate branch for node16

* remove temporary code

* update package.json

* changed pipeline

* updated pipeline

* Microsoft mandatory file (#839)

* Update pipeline to include a step for publishing artifacts. (#848) (#849)

* Update pipeline

* Update azure-pipelines.yml

* nodeversion as variable

* Added node16 to schema (#852)

Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>

* bump version (#862)

Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>

* Update ci-cd for publishing npm package (#863)

* fix npm publish

Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>

* fix add registry (#864)

Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>

* fix ToolRunner - _getSpawnSyncOptions (#873)

* Mockery version is updated from 1.7.0 to 2.1.0 because of vulnerability (#878)

* Fixed release path (#888)

* Improvement of the release condition (#889)

* Added test task with test condition. Negative test

* Added test task with test condition. Positive test

* Fix path

* Fix path

* Fix path

* Changed build.sourcebranchname -> build.sourcebranch and path to branch

* Fix path

* Version changed (#894)

* Pipeline fixing (#893)

* Token test

* Test token

* Publish test

* call order changed

* Nmp token syntax reverted

* Changed windows job

* Script clearing

* Uncommented condition

* Token changed

* Test - off publish condition

* Switched on publish condition

* Package version was reverted

* Add escape for more correct working

* Add changelog

* Update package-lock version

* Bump tl version to 4.1.0

* Update changelog

* Remove PS task lib changes from node changelog

* Update changelog for 4.0.1-preview

Co-authored-by: AndreyIvanov42 <93121155+AndreyIvanov42@users.noreply.github.com>
Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
Co-authored-by: Denis Rumyantsev <mr.denis.rumyantsev@gmail.com>
Co-authored-by: Roman-Shchukin <111063382+Roman-Shchukin@users.noreply.github.com>
@qianz2 qianz2 mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants