Enable task authors to determine whether the task is running on a hosted agent, or not. #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmapetr
approved these changes
Oct 7, 2022
| export function getAgentMode(): AgentHostedMode { | ||
| let agentCloudId = getVariable('Agent.CloudId'); | ||
|
|
||
| if (agentCloudId === undefined) |
There was a problem hiding this comment.
I suggest to check MsHosted and SelfHosted and for any other case just return unknown
There was a problem hiding this comment.
It would be a good idea, but here is a little bit of another logic. "undefined" value means that the current agent version doesn't support Agent.CloudId, it's for backward compatibility. Any other empty values mean it's SelfHosted and real value means MsHosted
ismayilov-ismayil
approved these changes
Oct 10, 2022
wojgasior
approved these changes
Oct 10, 2022
max-zaytsev
deleted the
users/roman-shchukin/expose_agent_hosting_model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added export function getAgentMode for getting the agent hosted type.
It works throw Agent.CloudId property.
Changelog:
Function getAgentMode added to task
Function getAgentMode added to mock
Documentation changes required: Yes
Added unit tests: No
Attached related issue: Link to PR in the issue