Added unhandledRejection event #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event "unhandledRejection" was added on process.on because when Promise is rejected and there is no catch
the error will not be thrown and process.on('uncaughtException') won't call for Node10 but it will emit "uncaughtException" for node 16.
So we need to listen to "unhandledRejection" and throw the error to make sure the error is thrown and the result will be similar.
KonstantinTyukalov
approved these changes
Jan 5, 2023
PavloAndriiesh
approved these changes
Jan 5, 2023
ismayilov-ismayil
approved these changes
Jan 5, 2023
kirill-ivlev
approved these changes
Jan 9, 2023
DmitriiBobreshev
deleted the
users/dmitriibobreshev/add-unhandledRejection-event
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem is that when we reject Promises, Node10 and Node16 behaviour is different.
For Node 10, when a promise was rejected without a .catch block will be emitted only unhandledRejection
For Node 16, when a promise was rejected without a .catch block will be emitted unhandledRejection first (if exists), and uncaughtException at the end.
In azure-pipelines-task-lib we handle all uncaughtExceptions and set TaskResult.Failed.
So when we use node16 runner, it emits uncaughtExceptions on Promise rejection and the task fails, and when we use node 10 it does not emit uncaughtExceptions so the task successfully finishes.
The event "unhandledRejection" was added on process.on to emit uncaughtExceptions on node10