Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps - Key Vault Task - Support Version identifiers in secret names #10445

Closed
rahulpnath opened this issue May 22, 2019 · 0 comments

Comments

@rahulpnath
Copy link
Contributor

commented May 22, 2019

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Feature

Enter Task Name: Azure Key Vault

list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

Environment

  • Server - Azure Pipelines or TFS on-premises? Azure Pipelines

Issue Description

The Key Vault Task should support version identifiers as part of the Secrets filter parameter.

Current Behaviour

When specifying a Secret Name along with the version identifier for Secrets filter parameter it fetches the appropriate version value of the secret. However, the value can be referenced only with the full name including the version guid.

For e.g.
Secrets filter: 'secret3/versionIdentifierGuid'

The task sets a parameter named 'secret3/versionIdentifierGuid'

Expected Behaviour

The task must set a parameter named 'secret3' (without the version guid in the name)

By doing this we can have each stage use it's own key vault instances but refer to a same name. Also the release created will snapshot the variable value at the point in time. At present it reads the latest version from the Key Vault (which can change over time). By locking in on the version guid for a secret, a release created will always have the same value no matter of the updates that happen for the secret in the key vault.

Since Key Vault secrets can contain only 0-9, a-z, A-Z, and - any one specifying '/' will be explicitly opting in for the versioning style.

@kmkumaran kmkumaran assigned bansalaseem and unassigned kmkumaran May 23, 2019

ds-ms added a commit that referenced this issue Jun 11, 2019

[AzureKeyVault] Split out version identifer from secret name (#10446)
When saving a secret with the GUID version identifier
specified, split out the name part and save the variable
against that name.

#10445

@ds-ms ds-ms closed this Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.