[CMakeV1] Made the task to be executed through shell. #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as 'shell' property of IExecOption object is set to 'true' the command will be executed with shell and environment variables will be properly interpreted for cmakeArgs.
…d_shell_exec_option
|
@egor-bryzgalov - There seems to be some issues with CI for this PR. Once all the tests are passing, I will review the PR. |
|
Also, @egor-bryzgalov, if you need assistance figuring out what is going on, please feel free to reach out and I can help dig in with you. |
…d_shell_exec_option
…d_shell_exec_option
|
You're going to have to update to the most recent version of the task-lib. Since its currently pinned to |
damccorm
reviewed
May 13, 2020
|
@jtpetty this should be ready for review from your team |
…d_shell_exec_option
egor-bryzgalov
deleted the
users/egor.bryzgalov/fix12848-CMakeV1-added_shell_exec_option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #12848
Made the task to be executed through shell specific for the environment to handle variables in command string properly.
NOTE: These changes in azure-pipelines-task-lib are required.