Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped MSBuildLogger version #15115

Conversation

anatolybolshakov
Copy link
Contributor

@anatolybolshakov anatolybolshakov commented Aug 3, 2021

Task name: MSBuildHelpers common package

Description: updated MSBuildHelpers package - to consume updated msbuildlogger. This resolves #14904 issue and adds some null checks to the logger.

Documentation changes required: N

Added unit tests: N

Attached related issue: Y

Checklist:

  • Task version was bumped - please check instruction how to do it - bumped package's version, tasks versions.
  • Checked that applied changes work as expected - currently we don't have exact repro steps to verify that it resolves original issue, checked that task works as expected for common cases with MSBuild/VSBuild tasks.

@anatolybolshakov anatolybolshakov requested a review from a team as a code owner August 3, 2021 11:15
@alexander-smolyakov alexander-smolyakov requested a review from a team August 3, 2021 11:18
@anatolybolshakov anatolybolshakov requested a review from a team August 5, 2021 10:00
Copy link
Contributor

@EzzhevNikita EzzhevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
But looks like it also need to bump XamarinAndroidV1 task version since it depends on msbuildhelpers

Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes manually, found no issues. LGTM, thanks!

@anatolybolshakov anatolybolshakov merged commit d54f05b into master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Devops pipelines crashing in MSBuild logger, as of 5/25 VS2019 image
4 participants