Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TwineAuthenticateV0-1 to Node 10 #15924

Conversation

AndreyIvanov42
Copy link
Contributor

Task name: TwineAuthenticateV0-1

Description: migrate task to Node 10

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AndreyIvanov42
Copy link
Contributor Author

Tested with pipeline for canary builds

@anatolybolshakov
Copy link
Contributor

@AndreyIvanov42 please check failed tests - can we fix it quickly or it would require some investigation of how task works?

@AndreyIvanov42
Copy link
Contributor Author

@anatolybolshakov Some investigation is need

@AndreyIvanov42
Copy link
Contributor Author

@anatolybolshakov
I increased timeout and this helped. PR is ready currently

@AndreyIvanov42
Copy link
Contributor Author

@geekzter

…-tasks into users/v-andivanov/migrate-twine-authenticateV0-node10
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/migrate-twine-authenticateV0-node10 branch from f39acd6 to 06c71ba Compare March 30, 2022 12:14
@AndreyIvanov42
Copy link
Contributor Author

@phil-hodgson @aasim @satbai Could you please review and approve the PR if all is fine?

@DmitriiBobreshev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

Test results are here

Risks analysis checklist

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how tasks are working, how changes affect task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@@ -9,14 +9,14 @@
"category": "Package",
"version": {
"Major": 1,
"Minor": 198,
"Minor": 201,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 207 instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 208 even at this moment

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jul 6, 2022

Hi @phil-hodgson, @aasim, @satbai Could you please take a look at this PR?

@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit 467ca13 into microsoft:master Jul 28, 2022
@AndreyIvanov42 AndreyIvanov42 deleted the users/v-andivanov/migrate-twine-authenticateV0-node10 branch July 28, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants