Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored WorkloadIdentityFederation support #18270

Merged
merged 12 commits into from
May 22, 2023

Conversation

starkmsu
Copy link
Contributor

Task name: AzureFunctionAppV1, AzureFunctionAppV2

Description: Restored WorkloadIdentityFederation support

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@PavloAndriiesh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Copy link
Contributor

@FinVamp1 FinVamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

While in general I understand using Azure-Arm-Rest-v2 helps avoid duplication of code it does mean that we have lost the targeted logging that differentiates Functions from App Service. I note that you have removed the Functions flavour of the App Service and Kudu classes which means that we lose the targeted logging for Functions,. console.log("##vso[telemetry.publish area=TaskDeploymentMethod;feature=AzureFunctionAppDeployment]" + authMethodtelemetry); . This may seem like a nit but we are trying to distinguish between the tasks so we can look into the telemetry and dientify failures before the task gets to us? Perhaps we can pass in parameter to the common logic?

Copy link
Contributor

@FinVamp1 FinVamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I think having the FileTransformationUtility as part of the shared packages is the right thing to do.

@starkmsu starkmsu merged commit a6a5533 into master May 22, 2023
12 checks passed
@starkmsu starkmsu deleted the users/snesterov/afa-wif-restore branch June 13, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants