Fix CargoAuthenticate for registries containing more than one dash #18421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one dash The `.replace` function only replaces the first dash, and we need to replace all of them when converting the name to an environment variable.
jmyersmsft
approved these changes
Jun 1, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
zhenghao104
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: CargoAuthenticateV0
Description: Bug fix. The
.replacefunction only replaces the first dash, and we need to replace all of them when converting the name to an environment variable.Documentation changes required: N
Added unit tests: No unit tests existed for this task
Attached related issue: N
Checklist: