[AzureSpringCloudV0] Using PUT method when deploying custom container app #19253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuoyuWang-MS
changed the title
RuoyuWang-MS
changed the title
allxiao
reviewed
Nov 14, 2023
_generated/AzureSpringCloudV0_Node20/deploymentProvider/azure-arm-spring-apps.ts
Show resolved
Hide resolved
allxiao
reviewed
Nov 14, 2023
allxiao
approved these changes
Nov 14, 2023
|
@mmrazik Please help merge this PR at your convenience. Thanks a lot! |
RuoyuWang-MS
force-pushed
the
ruoyu/dev1108
branch
from
84cd330
to
02b2893
Compare
|
Could we please get this merged? It would be nice to have this working during demos. |
DmitriiBobreshev
approved these changes
Jan 15, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
max-zaytsev
approved these changes
Jan 15, 2024
…es-tasks into ruoyu/dev1108
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@microsoft/azure-spring-apps @RuoyuWang-MS @anishp55 - Edit: for clarity: we provided @microsoft/azure-spring-apps write access to the repo for Microsoft development. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name:
AzureSpringCloudV0
Description:
Fix one bug when deploying custom container to Azure Spring Apps.
When deploy custom container in ASA, we should use PUT method instead of PATCH method.
Also need to keep other properties unchanged when deploying custom container app.
Documentation changes required: (Y/N)
N
Added unit tests: (Y/N)
N
Attached related issue: (Y/N)
Y
#19132
Checklist: